Use replaceAll
instead of an incorrect RegExp
for tsserver log sanitization.
#54454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use the TypeScript version as a raw input string for a
RegExp
and run it over TSServer logs. But that means that when you switch the version to5.1.2
a whole bunch of random strings with5
and1
and2
in them are replaced withFakeVersion
because we're really running/5.1.2/g
over the logs (which is5{AnyCharacter}1{AnyCharacter}2
).So this PR avoids constructing the incorrect
RegExp
by using areplaceAll
function which uses the newer built-in if it's available.