Disable JSX recovery hack when in unary expression context

[jakebailey]

Fixes #53114
Fixes #53637

I broke this in #52667 by adding a new call to the JSX element parser. That element parser has a unique recovery method which returns a BinaryExpression, but, this is incompatible with unary expressions, which cannot contain binary expressions.

[DanielRosenwasser]

I guess the fix here is okay - it seems overly-targeted to a specific code path though. My feeling is the right thing to do is to only do the recovery step when everything prior to the < had no errors.

[DanielRosenwasser]

also using "crash" in the test name - I'm not huge on it

[jakebailey]

I guess the fix here is okay - it seems overly-targeted to a specific code path though. My feeling is the right thing to do is to only do the recovery step when everything prior to the < had no errors.

If that were the implementation, then I think we'd end up crashing on this code too: ~<></> <, or the code that the comment above this code mentions + unary, so ~<div></div><div></div>. So I feel like the fix in this PR is correct.

also using "crash" in the test name - I'm not huge on it

I feel like we've somewhat consistently done this:

$ ls tests/cases/compiler | grep -i crash | wc -l
63

If it were me I'd call this test case issue53637.ts!

[DanielRosenwasser]

Duh - good point. Could you add that case though?

[jakebailey]

Yes, will do.

[jakebailey]

@typescript-bot cherry-pick this to release-5.0

[typescript-bot]

Heya @jakebailey, I've started to run the task to cherry-pick this into release-5.0 on this PR at 74e40e4. You can monitor the build here.

[typescript-bot]

Hey @jakebailey, I've opened #53676 for you.