fix: fail starting Snap if no exports found #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/fail-if-no-snap-exports
branch
from
4784653
to
fb15ac2
Compare
FrederikBolding
commented
Apr 24, 2024
| @@ -461,6 +461,9 @@ export class BaseSnapExecutor { | |||
| } | |||
| return acc; | |||
| }, {}); | |||
|
|
|||
| // If the Snap has no valid exports after this, fail. | |||
| assert(Object.keys(data.exports).length > 0, 'Snap has no valid exports.'); | |||
There was a problem hiding this comment.
This is the main change - everything else is testing related
Mrtenz
reviewed
Apr 24, 2024
packages/snaps-execution-environments/src/common/BaseSnapExecutor.test.browser.ts
Outdated
Show resolved
Hide resolved
…tor.test.browser.ts Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no valid exports were found during initial eval of the Snap, fail early instead of potentially throwing misleading errors later.