fix: gracefully handle errors for multiple failing requests #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/gracefully-handle-multiple-requests-erroring
branch
from
6f8c052
to
b628dd1
Compare
Mrtenz
approved these changes
Apr 22, 2024
FrederikBolding
deleted the
fb/gracefully-handle-multiple-requests-erroring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem where if multiple simultaneous requests were sent to a Snap that resulted in an error, termination would be attempted multiple times causing unintentional errors to be surfaced to the caller.
This is fixed by making sure
stopSnapis only called once even if we have multiple pending requests for the Snap.