fix: properly handle termination of Snaps while executing #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/properly-handling-termination-while-executing
branch
from
ea2fc0c
to
2456e16
Compare
FrederikBolding
changed the title
FrederikBolding
force-pushed
the
fb/properly-handling-termination-while-executing
branch
from
3e1bc06
to
7dc4cfa
Compare
Mrtenz
reviewed
Apr 23, 2024
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
FrederikBolding
force-pushed
the
fb/properly-handling-termination-while-executing
branch
from
fdd4bb5
to
bb49db2
Compare
Mrtenz
approved these changes
Apr 23, 2024
FrederikBolding
deleted the
fb/properly-handling-termination-while-executing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where terminating a Snap that is currently executing (e.g. when removing it) would cause unexpected errors to be thrown.
Fixes #2300