Remove dead code in snaps-rpc-methods
#2050
Merged
+85
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
approved these changes
Jan 3, 2024
FrederikBolding
force-pushed
the
fb/remove-rpc-methods-dead-code
branch
from
8686b82 to
7f72879
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
==========================================
+ Coverage 96.22% 96.28% +0.05%
==========================================
Files 271 270 -1
Lines 6310 6300 -10
Branches 1019 1017 -2
==========================================
- Hits 6072 6066 -6
+ Misses 238 234 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some dead code in snaps-rpc-methods and increase testing coverage of error cases. Also changes an error to throw using the proper JSON-RPC error code.