feat: support updated EIP-5792 specification #363
Merged
+171
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
previously approved these changes
Mar 12, 2025
adonesky1
reviewed
Mar 12, 2025
mcmire
reviewed
Mar 12, 2025
jiexi
reviewed
Mar 12, 2025
jiexi
reviewed
Mar 12, 2025
jiexi
approved these changes
Mar 12, 2025
cryptotavares
approved these changes
Mar 12, 2025
7 tasks
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 14, 2025
## **Description** Support updated EIP-5792 specification. See [#363](MetaMask/eth-json-rpc-middleware#363) for specification changes. Specifically: - Add `GetCallsStatus` hook. - Throw if any non-optional capabilities specified in `wallet_sendCalls`. - Throw if `version` not supported in `wallet_sendCalls`. - Locate transaction using `batchId`. - Return empty object from `wallet_getCapabilities`. - Return standardised `status` code from `wallet_getCallsStatus`. - Update `@metamask/transaction-controller` to `49.0.0`. - Update `@metamask/eth-json-rpc-middleware` to `16.0.0`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30967?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/30967?quickstart=1){kind=link}
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 14, 2025
## **Description** Support updated EIP-5792 specification. See [#363](MetaMask/eth-json-rpc-middleware#363) for specification changes. Specifically: - Add `GetCallsStatus` hook. - Throw if any non-optional capabilities specified in `wallet_sendCalls`. - Throw if `version` not supported in `wallet_sendCalls`. - Locate transaction using `batchId`. - Return empty object from `wallet_getCapabilities`. - Return standardised `status` code from `wallet_getCallsStatus`. - Update `@metamask/transaction-controller` to `49.0.0`. - Update `@metamask/eth-json-rpc-middleware` to `16.0.0`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30967?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 14, 2025
## **Description** Support updated EIP-5792 specification. See [#363](MetaMask/eth-json-rpc-middleware#363) for specification changes. Specifically: - Add `GetCallsStatus` hook. - Throw if any non-optional capabilities specified in `wallet_sendCalls`. - Throw if `version` not supported in `wallet_sendCalls`. - Locate transaction using `batchId`. - Return empty object from `wallet_getCapabilities`. - Return standardised `status` code from `wallet_getCallsStatus`. - Update `@metamask/transaction-controller` to `49.0.0`. - Update `@metamask/eth-json-rpc-middleware` to `16.0.0`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30967?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
matthewwalsh0
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2025
## **Description** Support updated EIP-5792 specification. See [#363](MetaMask/eth-json-rpc-middleware#363) for specification changes. Specifically: - Add `GetCallsStatus` hook. - Throw if any non-optional capabilities specified in `wallet_sendCalls`. - Throw if `version` not supported in `wallet_sendCalls`. - Locate transaction using `batchId`. - Return empty object from `wallet_getCapabilities`. - Return standardised `status` code from `wallet_getCallsStatus`. - Update `@metamask/transaction-controller` to `49.0.0`. - Update `@metamask/eth-json-rpc-middleware` to `16.0.0`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30967?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
matthewwalsh0
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2025
## **Description** Support updated EIP-5792 specification. See [#363](MetaMask/eth-json-rpc-middleware#363) for specification changes. Specifically: - Add `GetCallsStatus` hook. - Throw if any non-optional capabilities specified in `wallet_sendCalls`. - Throw if `version` not supported in `wallet_sendCalls`. - Locate transaction using `batchId`. - Return empty object from `wallet_getCapabilities`. - Return standardised `status` code from `wallet_getCallsStatus`. - Update `@metamask/transaction-controller` to `49.0.0`. - Update `@metamask/eth-json-rpc-middleware` to `16.0.0`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30967?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
matthewwalsh0
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 17, 2025
## **Description** Support updated EIP-5792 specification. See [#363](MetaMask/eth-json-rpc-middleware#363) for specification changes. Specifically: - Add `GetCallsStatus` hook. - Throw if any non-optional capabilities specified in `wallet_sendCalls`. - Throw if `version` not supported in `wallet_sendCalls`. - Locate transaction using `batchId`. - Return empty object from `wallet_getCapabilities`. - Return standardised `status` code from `wallet_getCallsStatus`. - Update `@metamask/transaction-controller` to `49.0.0`. - Update `@metamask/eth-json-rpc-middleware` to `16.0.0`. [](https://codespaces.new/MetaMask/metamask-extension/pull/30967?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the EIP-5792 support following changes to the specification.
Specifically:
wallet_sendCallsid.capabilitiesper call.optionalproperty in capabilities.idand optionalcapabilities.wallet_getCallsStatusid.id,version, and optionalcapabilitiesto result.statusto number.GetCallsStatusCodeenum.GetCallsStatusHook.wallet_getCapabilitieschainIdsargument.