-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network sync - add main sync logic #4694
Merged
Merged
+721
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/profile-sync-controller/src/controllers/user-storage/network-syncing/sync-all.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/network-syncing/sync-all.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/network-syncing/sync-all.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/network-syncing/sync-all.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/network-syncing/types.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/network-syncing/types.ts
Show resolved
Hide resolved
another PR will add the controller integration.
af1bb32
to
c6ea36e
Compare
Loading status checks…
…network-sync-all
mathieuartu
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job! I might re-use some of the way you laid out your logic, as I think it makes better sense for future use of the batch PUT endpoint.
Nice coverage as well, wooo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team-notifications
Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This adds support for the "main-sync" on network syncing feature. This will get all a users local networks, and saved remote networks; then will append/update/delete networks synced across their devices.
We will add the controller integration in a following PR.
References
https://consensyssoftware.atlassian.net/browse/NOTIFY-1040
Changelog
@metamask/profile-sync-controller
sync.ts
file tosync-mutations.ts
utils
to theUserStorageController
subpath.findNetworksToUpdate()
function which will perform the "main-sync" logic for local and remote network configurations.Checklist