feat: add a canSync check for account syncing

[mathieuartu]

Explanation

This PR ensures we don't fire account syncing if the conditions are not entirely met.

References

Changelog

@metamask/profile-sync-controller

• ADDED: Add a canSync check to account syncing

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[Prithpal-Sooriya]

Yep fair.

The assert seems to just check state

core/packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

Lines 638 to 644 in 6cf64c6

	#assertProfileSyncingEnabled(): void {
	if (!this.state.isProfileSyncingEnabled) {
	throw new Error(
	`${controllerName}: Unable to call method, user is not authenticated`,
	);
	}
	}

We might be able just create a safe one of these or copy the line.

[Prithpal-Sooriya]

I think the try/catch is still valid, since not sure what this.#auth.isAuthEnabled would call under the hood or in the future (if it changes)

[mathieuartu]

this.#auth.isAuthEnabled checks the state of AuthenticationController in order to get isSignedIn.

I agree, I don't think it's 100% ideal to be honest, and we're again going to be checking UI-side if all of this is enabled. I'll look into it when I have a bit less on my plate to kind of centralize these checks.