Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Bump prettier to ^3.3.3 #202

Merged
merged 4 commits into from
Sep 23, 2024
Merged

BREAKING: Bump prettier to ^3.3.3 #202

merged 4 commits into from
Sep 23, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Sep 23, 2024

This bumps Prettier to ^3.3.3, and fixes any breaking changes in Prettier.

Closes #201.

Breaking changes

  • prettier@^3.3.3 is now a peer-dependency of this package.
  • Changelog.toString now returns a Promise, which resolves with the formatted changelog.

@Mrtenz Mrtenz requested a review from a team as a code owner September 23, 2024 13:37
Copy link

socket-security bot commented Sep 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/code-frame@7.24.7 environment 0 24.1 kB nicolo-ribaudo
npm/@babel/compat-data@7.25.4 None 0 101 kB nicolo-ribaudo
npm/@babel/core@7.25.2 environment, filesystem, unsafe 0 788 kB nicolo-ribaudo
npm/@babel/generator@7.25.6 None 0 487 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.25.2 None 0 52.3 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.24.7 None 0 63.7 kB nicolo-ribaudo
npm/@babel/helper-module-transforms@7.25.2 None 0 160 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.8 None 0 114 kB nicolo-ribaudo
npm/@babel/helper-simple-access@7.24.7 None 0 14.1 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.8 None 0 31.8 kB nicolo-ribaudo
npm/@babel/helper-validator-identifier@7.24.7 None 0 49.3 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.24.8 None 0 11.8 kB nicolo-ribaudo
npm/@babel/helpers@7.25.6 None 0 928 kB nicolo-ribaudo
npm/@babel/highlight@7.24.7 environment 0 20.3 kB nicolo-ribaudo
npm/@babel/parser@7.25.6 None 0 1.89 MB nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.24.7 None 0 70 kB nicolo-ribaudo
npm/@babel/plugin-syntax-typescript@7.25.4 None 0 69.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/template@7.25.0 None 0 70.4 kB nicolo-ribaudo
npm/@babel/traverse@7.25.6 None 0 731 kB nicolo-ribaudo
npm/@babel/types@7.25.6 environment 0 2.48 MB nicolo-ribaudo
npm/@istanbuljs/schema@0.1.3 None 0 17.2 kB coreyfarrell
npm/@jest/console@29.7.0 None 0 19 kB simenb
npm/@jest/core@29.7.0 unsafe 0 145 kB simenb
npm/@jest/environment@29.7.0 None 0 15.9 kB simenb
npm/@jest/expect-utils@29.7.0 None 0 28.3 kB simenb
npm/@jest/expect@29.7.0 None 0 5.23 kB simenb
npm/@jest/fake-timers@29.7.0 None 0 26.3 kB simenb
npm/@jest/globals@29.7.0 None 0 5.26 kB simenb
npm/@jest/reporters@29.7.0 environment, unsafe 0 115 kB simenb
npm/@jest/source-map@29.6.3 None 0 5.07 kB simenb
npm/@jest/test-result@29.7.0 None 0 15.8 kB simenb
npm/@jest/test-sequencer@29.7.0 None 0 13.6 kB simenb
npm/@jest/transform@29.7.0 None 0 52.4 kB simenb
npm/@jridgewell/gen-mapping@0.3.5 None 0 81.6 kB jridgewell
npm/@jridgewell/set-array@1.2.1 None 0 17.9 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 None 0 169 kB jridgewell
npm/@pkgr/core@0.1.1 None 0 8.54 kB jounqin
npm/@sinonjs/commons@3.0.1 None 0 38 kB mrgnrdrck
npm/@sinonjs/fake-timers@10.3.0 eval 0 80.1 kB fatso83
npm/@types/babel__core@7.20.5 None 0 33 kB types
npm/@types/graceful-fs@4.1.9 None 0 3.9 kB types
npm/async@3.2.6 None 0 808 kB aearly
npm/babel-jest@29.7.0 environment 0 13.5 kB simenb
npm/babel-plugin-jest-hoist@29.6.3 None 0 14.3 kB simenb
npm/babel-preset-jest@29.6.3 None 0 2.69 kB simenb
npm/browserslist@4.23.3 environment, filesystem 0 63 kB ai
npm/camelcase@6.3.0 None 0 11.7 kB sindresorhus
npm/caniuse-lite@1.0.30001663 None 0 0 B
npm/chalk@4.1.2 None 0 35 kB sindresorhus
npm/ci-info@3.9.0 environment 0 26.1 kB sibiraj-s
npm/cjs-module-lexer@1.4.1 None 0 146 kB guybedford
npm/cliui@8.0.1 None 0 32.3 kB oss-bot
npm/create-jest@29.7.0 None 0 15.9 kB simenb
npm/debug@4.3.7 environment 0 42.1 kB qix
npm/dedent@1.5.3 None 0 23.9 kB joshuakgoldberg
npm/detect-indent@7.0.1 None 0 9.75 kB sindresorhus
npm/ejs@3.1.10 eval, filesystem 0 143 kB mde
npm/electron-to-chromium@1.5.27 None 0 148 kB kilianvalkhof
npm/emittery@0.13.1 None 0 46.5 kB sindresorhus
npm/escalade@3.2.0 filesystem 0 12.4 kB lukeed
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-plugin-prettier@5.2.1 None 0 34.3 kB jounqin
npm/expect@29.7.0 None 0 146 kB simenb
npm/fast-glob@3.3.2 filesystem 0 96.7 kB mrmlnc
npm/filelist@1.0.4 filesystem 0 18.6 kB mde
npm/fsevents@2.3.3 None 0 173 kB pipobscure
npm/get-stdin@9.0.0 None 0 4.54 kB sindresorhus
npm/git-hooks-list@3.1.0 None 0 5.57 kB fisker
npm/graceful-fs@4.2.11 environment, filesystem 0 32.5 kB isaacs
npm/ignore@5.3.2 None 0 53.6 kB kael
npm/is-plain-obj@4.1.0 None 0 4.08 kB sindresorhus
npm/istanbul-lib-instrument@6.0.3 None 0 72 kB oss-bot
npm/istanbul-reports@3.1.7 None 0 294 kB oss-bot
npm/jake@10.9.2 environment, filesystem, shell 0 175 kB mde
npm/jest-changed-files@29.7.0 environment 0 18.2 kB simenb
npm/jest-circus@29.7.0 unsafe 0 72 kB simenb
npm/jest-cli@29.7.0 None 0 33.8 kB simenb
npm/jest-config@29.7.0 None 0 114 kB simenb
npm/jest-docblock@29.7.0 None 0 8.99 kB simenb
npm/jest-each@29.7.0 None 0 33.7 kB simenb
npm/jest-environment-node@29.7.0 unsafe 0 9.37 kB simenb
npm/jest-haste-map@29.7.0 environment, filesystem, shell, unsafe 0 121 kB simenb
npm/jest-leak-detector@29.7.0 unsafe 0 5.59 kB simenb
npm/jest-matcher-utils@29.7.0 None 0 28.4 kB simenb
npm/jest-message-util@29.7.0 None 0 20.6 kB simenb
npm/jest-mock@29.7.0 None 0 47.5 kB simenb
npm/jest-regex-util@29.6.3 None 0 3.52 kB simenb
npm/jest-resolve-dependencies@29.7.0 None 0 8.92 kB simenb
npm/jest-resolve@29.7.0 environment, unsafe 0 65.7 kB simenb
npm/jest-runner@29.7.0 environment 0 29.6 kB simenb
npm/jest-runtime@29.7.0 unsafe 0 89.2 kB simenb
npm/jest-snapshot@29.7.0 eval 0 83.5 kB simenb
npm/jest-util@29.7.0 environment 0 41.8 kB simenb
npm/jest-validate@29.7.0 None 0 28.7 kB simenb
npm/jest-watcher@29.7.0 None 0 23.4 kB simenb
npm/jest-worker@29.7.0 environment, shell 0 90.8 kB simenb
npm/jest@29.7.0 None 0 5.01 kB simenb
npm/lodash.memoize@4.1.2 None 0 20.1 kB jdalton
npm/lru-cache@5.1.1 None 0 15.7 kB isaacs
npm/makeerror@1.0.12 None 0 6.07 kB daaku
npm/ms@2.1.3 None 0 6.72 kB styfle
npm/node-releases@2.0.18 None 0 35.7 kB chicoxyzzy
npm/parse-json@5.2.0 None 0 5.41 kB sindresorhus
npm/picocolors@1.1.0 environment 0 11.4 kB alexeyraspopov
npm/pirates@4.0.6 unsafe 0 13.5 kB danez
npm/prettier-plugin-packagejson@2.5.2 None 0 5.55 kB matzkoh
npm/prettier@3.3.3 environment, filesystem, unsafe 0 7.7 MB prettier-bot
npm/pure-rand@6.1.0 None 0 84 kB ndubien
npm/resolve.exports@2.0.2 None 0 23.9 kB lukeed
npm/semver@7.6.3 None 0 95.8 kB npm-cli-ops
npm/sort-object-keys@1.1.3 None 0 2.69 kB keithamus
npm/sort-package-json@2.10.1 None 0 33.3 kB keithamus
npm/source-map-support@0.5.13 filesystem, unsafe 0 82.5 kB linusu
npm/stack-utils@2.0.6 unsafe 0 14.6 kB isaacs
npm/synckit@0.9.1 environment 0 55.7 kB jounqin
npm/ts-jest@29.2.5 None 0 328 kB anhpnnd, kul, tsjest
npm/update-browserslist-db@1.1.0 environment, filesystem, shell 0 14.8 kB ai
npm/v8-to-istanbul@9.3.0 filesystem, unsafe 0 47.6 kB oss-bot
npm/walker@1.0.8 filesystem 0 5.8 kB daaku
npm/write-file-atomic@4.0.2 filesystem 0 12.2 kB gar
npm/yargs-parser@21.1.1 environment, filesystem 0 128 kB oss-bot
npm/yargs@17.7.2 environment, filesystem 0 292 kB oss-bot

🚮 Removed packages: npm/@babel/code-frame@7.22.13, npm/@babel/compat-data@7.23.2, npm/@babel/core@7.23.2, npm/@babel/generator@7.23.0, npm/@babel/helper-compilation-targets@7.22.15, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-hoist-variables@7.22.5, npm/@babel/helper-module-imports@7.22.15, npm/@babel/helper-module-transforms@7.23.0, npm/@babel/helper-plugin-utils@7.22.5, npm/@babel/helper-simple-access@7.22.5, npm/@babel/helper-split-export-declaration@7.22.6, npm/@babel/helper-string-parser@7.22.5, npm/@babel/helper-validator-identifier@7.22.20, npm/@babel/helper-validator-option@7.22.15, npm/@babel/helpers@7.23.2, npm/@babel/highlight@7.22.20, npm/@babel/parser@7.23.0, npm/@babel/template@7.22.15, npm/@babel/traverse@7.23.2, npm/@babel/types@7.23.0, npm/@cnakazawa/watch@1.0.4, npm/@istanbuljs/schema@0.1.2, npm/@jest/console@26.6.2, npm/@jest/core@26.6.3, npm/@jest/environment@26.6.2, npm/@jest/fake-timers@26.6.2, npm/@jest/globals@26.6.2, npm/@jest/reporters@26.6.2, npm/@jest/source-map@26.6.2, npm/@jest/test-result@26.6.2, npm/@jest/test-sequencer@26.6.3, npm/@jest/transform@26.6.2, npm/@jridgewell/gen-mapping@0.3.3, npm/@jridgewell/set-array@1.1.2, npm/@jridgewell/trace-mapping@0.3.19, npm/@sinonjs/commons@1.8.1, npm/@sinonjs/fake-timers@6.0.1, npm/@types/babel__core@7.1.9, npm/@types/graceful-fs@4.1.3, npm/@types/normalize-package-data@2.4.0, npm/@types/prettier@2.1.0, npm/abab@2.0.5, npm/acorn-globals@6.0.0, npm/acorn-walk@7.2.0, npm/babel-jest@26.6.3, npm/babel-plugin-jest-hoist@26.6.2, npm/babel-preset-jest@26.6.2, npm/browser-process-hrtime@1.0.0, npm/browserslist@4.22.1, npm/camelcase@6.0.0, npm/caniuse-lite@1.0.30001550, npm/capture-exit@2.0.0, npm/chalk@4.1.0, npm/ci-info@2.0.0, npm/cjs-module-lexer@0.6.0, npm/cliui@7.0.4, npm/cssom@0.4.4, npm/cssstyle@2.3.0, npm/data-urls@2.0.0, npm/debug@4.3.4, npm/decimal.js@10.2.1, npm/domexception@2.0.1, npm/electron-to-chromium@1.4.557, npm/emittery@0.7.1, npm/escalade@3.1.1, npm/escodegen@2.0.0, npm/eslint-config-prettier@8.5.0, npm/eslint-plugin-prettier@4.2.1, npm/esprima@4.0.1, npm/exec-sh@0.3.4, npm/expect@26.6.2, npm/fast-glob@3.2.12, npm/fsevents@2.1.3, npm/graceful-fs@4.2.10, npm/growly@1.3.0, npm/hosted-git-info@2.8.9, npm/html-encoding-sniffer@2.0.1, npm/iconv-lite@0.4.24, npm/ignore@5.2.0, npm/is-ci@2.0.0, npm/is-docker@2.1.1, npm/is-potential-custom-element-name@1.0.0, npm/is-wsl@2.2.0, npm/istanbul-lib-instrument@4.0.3, npm/istanbul-reports@3.0.2, npm/jest-changed-files@26.6.2, npm/jest-cli@26.6.3, npm/jest-config@26.6.3, npm/jest-docblock@26.0.0, npm/jest-each@26.6.2, npm/jest-environment-jsdom@26.6.2, npm/jest-environment-node@26.6.2, npm/jest-haste-map@26.6.2, npm/jest-jasmine2@26.6.3, npm/jest-leak-detector@26.6.2, npm/jest-matcher-utils@26.6.2, npm/jest-message-util@26.6.2, npm/jest-mock@26.6.2, npm/jest-regex-util@26.0.0, npm/jest-resolve-dependencies@26.6.3, npm/jest-resolve@26.6.2, npm/jest-runner@26.6.3, npm/jest-runtime@26.6.3, npm/jest-serializer@26.6.2, npm/jest-snapshot@26.6.2, npm/jest-util@26.6.2, npm/jest-validate@26.6.2, npm/jest-watcher@26.6.2, npm/jest-worker@26.6.2, npm/jest@26.6.3, npm/jsdom@16.5.2, npm/lodash@4.17.21, npm/lru-cache@6.0.0, npm/makeerror@1.0.11, npm/ms@2.1.2, npm/node-modules-regexp@1.0.0, npm/node-notifier@8.0.1, npm/node-releases@2.0.13, npm/normalize-package-data@2.5.0, npm/nwsapi@2.2.0, npm/p-each-series@2.1.0, npm/parse-json@5.1.0, npm/parse5@6.0.1, npm/picocolors@1.0.0, npm/pirates@4.0.1, npm/prettier@2.8.8, npm/read-pkg-up@7.0.1, npm/read-pkg@5.2.0, npm/request-promise-core@1.1.4, npm/request-promise-native@1.0.9, npm/rsvp@4.8.5, npm/sane@4.1.0, npm/saxes@5.0.1, npm/semver@7.3.8, npm/shellwords@0.1.1, npm/source-map-support@0.5.19, npm/spdx-correct@3.1.1, npm/stack-utils@2.0.2, npm/stealthy-require@1.1.1, npm/supports-hyperlinks@2.1.0, npm/symbol-tree@3.2.4, npm/terminal-link@2.1.1, npm/throat@5.0.0, npm/tr46@2.0.2, npm/ts-jest@26.5.6, npm/typedarray-to-buffer@3.1.5, npm/update-browserslist-db@1.0.13, npm/v8-to-istanbul@7.1.1, npm/validate-npm-package-license@3.0.4, npm/w3c-hr-time@1.0.2, npm/w3c-xmlserializer@2.0.0, npm/walker@1.0.7, npm/webidl-conversions@5.0.0, npm/whatwg-encoding@1.0.5, npm/whatwg-mimetype@2.3.0, npm/whatwg-url@8.5.0, npm/write-file-atomic@3.0.3, npm/ws@7.5.0, npm/xml-name-validator@3.0.0, npm/xmlchars@2.2.0, npm/yargs-parser@20.2.7, npm/yargs@17.0.1

View full report↗︎

Copy link

socket-security bot commented Sep 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/create-jest@29.7.0, npm/jake@10.9.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Sep 23, 2024

@SocketSecurity ignore npm/create-jest@29.7.0

New author ok.

@SocketSecurity ignore npm/jake@10.9.2

Shell access expected.

Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -107,7 +107,7 @@ type ValidateChangelogOptions = {
* `true` and the changelog contains uncategorized changes.
* @throws `ChangelogFormattingError` - Will throw if there is a formatting error.
*/
export function validateChangelog({
export async function validateChangelog({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: README should be updated with the new API (though, I believe it should be updated with other things as well i.e. node version)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do in a separate PR.

@Mrtenz Mrtenz merged commit 0a736b6 into main Sep 23, 2024
14 checks passed
@Mrtenz Mrtenz deleted the mrtenz/prettier-3 branch September 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Prettier to v3
2 participants