Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of positional arguments on Import, New Browser, New Context & New Persistent Context #2328

Closed
Snooz82 opened this issue Sep 23, 2022 · 1 comment
Milestone

Comments

@Snooz82
Copy link
Member

Snooz82 commented Sep 23, 2022

Positional arguments are nice when there are three or four.
But Keywords like New Context have 30 or even more arguments.
Positional arguments are totally useless in that case.
But named arguments are pretty good.

The problem was, that because we had normal arguments, they could be used positional and named.
Therefore the order was fixed. We could not order them alphabetically or add a new arguments somewhere in the middle.

The fix is to switch all arguments to "named-only-arguments"!
We are hereby deprecating positional arguments (or the most of them) on the before mentioned keywords.
They can still be used in the old order, but shall be changed to positional arguments asap.

Support will be remove early 2023.

fixed in #2308

@Snooz82 Snooz82 added this to the v14.0.0 milestone Sep 23, 2022
@Snooz82
Copy link
Member Author

Snooz82 commented Sep 23, 2022

Fixed by #2308

@Snooz82 Snooz82 closed this as completed Sep 23, 2022
@Snooz82 Snooz82 added enhancement New feature or request priority: medium labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant