Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome extension support. Do not use eval #276

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

rahuljayaraman
Copy link
Contributor

@rahuljayaraman rahuljayaraman commented Feb 6, 2023

I would like to use lyra in a chrome extension, but chrome does not allow eval in extensions.

@rahuljayaraman rahuljayaraman changed the title fix: do not use eval to fetch values from nested objects Chrome extension support. Do not use eval Feb 8, 2023
Copy link
Member

@micheleriva micheleriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micheleriva micheleriva merged commit 0aa5474 into oramasearch:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants