Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and tests for how to save and load metrics #2237

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 23, 2023

What does this PR do?

Fixes #2223
Adds documentation and tests for how to save and load metrics.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2237.org.readthedocs.build/en/2237/

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2237 (2e6a61b) into master (0cb4c79) will decrease coverage by 48%.
Report is 1 commits behind head on master.
The diff coverage is 4%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2237     +/-   ##
========================================
- Coverage      87%     39%    -48%     
========================================
  Files         293     293             
  Lines       16426   16432      +6     
========================================
- Hits        14277    6332   -7945     
- Misses       2149   10100   +7951     

@mergify mergify bot added ready and removed ready labels Nov 23, 2023
@Borda Borda enabled auto-merge (squash) November 23, 2023 15:44
@mergify mergify bot added the ready label Nov 23, 2023
@Borda Borda disabled auto-merge November 28, 2023 16:00
@Borda Borda merged commit f45945e into master Nov 28, 2023
@Borda Borda deleted the docs/saving_loading branch November 28, 2023 16:01
Borda pushed a commit that referenced this pull request Nov 30, 2023
Borda pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when calling .to('cpu') on a CUDA metric loaded on a CPU-only machine
3 participants