Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify on num instead of nb or n #2090

Merged
merged 5 commits into from
Sep 21, 2023
Merged

refactor: unify on num instead of nb or n #2090

merged 5 commits into from
Sep 21, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 19, 2023

What does this PR do?

Unify the usage of num, nb and n if possible

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2090.org.readthedocs.build/en/2090/

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2090 (773187b) into master (6bf705e) will decrease coverage by 0%.
The diff coverage is 82%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2090   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         293     293           
  Lines       16304   16299    -5     
======================================
- Hits        14182   14177    -5     
  Misses       2122    2122           

@Borda Borda enabled auto-merge (squash) September 19, 2023 17:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Borda Borda requested a review from a team September 20, 2023 15:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mergify mergify bot added the ready label Sep 21, 2023
@Borda Borda disabled auto-merge September 21, 2023 08:01
@Borda Borda merged commit 25bf259 into master Sep 21, 2023
@Borda Borda deleted the refactor/n-nb-num branch September 21, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants