Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes before next release #2086

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Minor fixes before next release #2086

merged 6 commits into from
Sep 19, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 18, 2023

What does this PR do?

Fixes

  • Missing changelog entry
  • Missing metric .rst file in docs
  • Wrong rendering of headers, math and lists in some of the new clustering metrics
  • Wrong examples for plotting multiple values
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2086.org.readthedocs.build/en/2086/

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Sep 18, 2023
@SkafteNicki SkafteNicki added this to the v1.2.0 milestone Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2086 (6732f2f) into master (fe5f46f) will decrease coverage by 50%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2086     +/-   ##
========================================
- Coverage      87%     37%    -50%     
========================================
  Files         293     293             
  Lines       16304   16304             
========================================
- Hits        14182    6039   -8143     
- Misses       2122   10265   +8143     

@mergify mergify bot added the ready label Sep 18, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
@Borda Borda enabled auto-merge (squash) September 19, 2023 13:19
@Borda Borda merged commit 462e4fd into master Sep 19, 2023
@Borda Borda deleted the docs/clustering branch September 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready topic: Cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants