Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on wrappers to overview pages #2085

Merged
merged 12 commits into from
Sep 19, 2023
Merged

Add section on wrappers to overview pages #2085

merged 12 commits into from
Sep 19, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 18, 2023

What does this PR do?

Fixes #2079

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2085.org.readthedocs.build/en/2085/

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Sep 18, 2023
@SkafteNicki SkafteNicki added this to the v1.2.0 milestone Sep 18, 2023
@mergify mergify bot added the ready label Sep 18, 2023
@mergify mergify bot requested a review from a team September 18, 2023 09:03
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkafteNicki mind checking: UserWarning: The ``compute`` method of metric SumMetric was called before the ``update`` method which may lead to errors, as metric states have not yet been updated.

@Borda Borda enabled auto-merge (squash) September 19, 2023 17:01
@Borda Borda disabled auto-merge September 19, 2023 17:02
@Borda Borda enabled auto-merge (squash) September 19, 2023 17:02
@Borda Borda merged commit 6bf705e into master Sep 19, 2023
@Borda Borda deleted the docs/wrappers branch September 19, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discoverability of the wrappers
3 participants