-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeanAveragePrecision
backend
#2034
Merged
Merged
+533
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2034 +/- ##
======================================
Coverage 87% 87%
======================================
Files 285 285
Lines 15993 16021 +28
======================================
+ Hits 13871 13916 +45
+ Misses 2122 2105 -17 |
Borda
approved these changes
Aug 31, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
justusschock
approved these changes
Sep 6, 2023
matsumotosan
pushed a commit
to matsumotosan/torchmetrics
that referenced
this pull request
Sep 19, 2023
* implementation * imports + requirements + links * add tests * clarify language * Apply suggestions from code review * fix line length --------- Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
ready
topic: Detect
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1153
Fixes #2035
Adds a
backend
argument toMeanAveragePrecision
. The officialpycocotools
implementation we use is flawed as there are certain corner cases were the implementation does not work. Sadly the implementation is not really maintained any more. However, it is still considered the "official" implementation and therefore we cannot do so much about this.This PR adds the possibility of other backends for computation, starting with https://github.com/MiXaiLL76/faster_coco_eval which is a faster version and fixes at least the corner case identified in the linked issue. I still think we need to keep
pycocotools
as the default backend even if all the testing I have done shows that the two backends produce identical results.The goal for the future would be to reintroduce our old pytorch implementation with
backend="pytorch"
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2034.org.readthedocs.build/en/2034/