Total Variation Loss #978
Total Variation Loss #978
Conversation
Initialize the PR.
ragavvenkatesan
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
========================================
- Coverage 86% 38% -48%
========================================
Files 193 195 +2
Lines 11404 11461 +57
========================================
- Hits 9778 4303 -5475
- Misses 1626 7158 +5532 |
|
@ragavvenkatesan how is it going here? 🐰 |
|
So, I was waiting on you folks for some feedback on the initial code. I am working on tests this weekend, I can prioritize for next release since you brought it up. |
|
So, @Borda I think the metric is implemented. I working on unit test (taking suggestions for tests now). I have tested this on actual model training and seems like it is working as expected. Let me know how this looks. |
for more information, see https://pre-commit.ci
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
|
Addressed all comments @SkafteNicki Anything on tests? |
|
@ragavvenkatesan, could you pls check and resolve conflicts? 🦦 |
|
It seems to be failing for all the latest tests; in fact, it hangs and dies... |
What does this PR do?
This PR adds Total Variation Loss.
Fixes #972
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃