Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cornercase for PearsonCorrCoef #1587

Merged
merged 2 commits into from Mar 5, 2023
Merged

Fix cornercase for PearsonCorrCoef #1587

merged 2 commits into from Mar 5, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1559
Fix a corner case where PearsonCorrCoef is evaluated in ddp mode, num_output > 1 but with only a single device.
Added test that the function that needs to do the reduction correctly evaluate different combinations.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 5, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 5, 2023
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #1587 (deabc7c) into master (7f01332) will decrease coverage by 50%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1587     +/-   ##
========================================
- Coverage      88%     39%    -50%     
========================================
  Files         225     225             
  Lines       11860   11862      +2     
========================================
- Hits        10466    4590   -5876     
- Misses       1394    7272   +5878     

@mergify mergify bot added the ready label Mar 5, 2023
@mergify mergify bot requested a review from a team March 5, 2023 15:26
@stancld stancld merged commit d01f1fd into master Mar 5, 2023
@stancld stancld deleted the fix/pearson_cornercase branch March 5, 2023 20:40
Borda pushed a commit that referenced this pull request Mar 10, 2023
* fix
* changelog

(cherry picked from commit d01f1fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PearsonCorrCoef UnboundLocalError using ddp
3 participants