Fix type hints #1472
Merged
Fix type hints #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Assign MetricTracker.best_metric return value to a tuple of the form (best, idx), instead of (idx, best).
ValerianRey
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1472 +/- ##
========================================
- Coverage 90% 38% -52%
========================================
Files 213 213
Lines 10921 10921
========================================
- Hits 9794 4162 -5632
- Misses 1127 6759 +5632 |
Borda
approved these changes
Feb 1, 2023
SkafteNicki
approved these changes
Feb 1, 2023
stancld
approved these changes
Feb 1, 2023
Borda
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Fix return type in MetricTracker.compute_all * Fix return type in MetricTracker.best_metric * Fix test_best_metric_for_not_well_defined_metric_collection * Assign MetricTracker.best_metric return value to a tuple of the form (best, idx), instead of (idx, best). * changelog * add docstring --------- Co-authored-by: SkafteNicki <skaftenicki@gmail.com> (cherry picked from commit fbdc393)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes some type hints in MetricTracker, which do not correspond to the possible return types of the methods.
It also fixes in a test a confusion in the order of the tuple (value, index) returned by MetricTracker.best_metric (the order now matches the type hint and the type hint now matches the doc).
Before submitting
PR review
Did you have fun?
Yes!