Add missing dtype check in PrecisionRecallCurve #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted to the internet
for more information, see https://pre-commit.ci
SkafteNicki
requested review from
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
SkafteNicki
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
========================================
- Coverage 90% 51% -38%
========================================
Files 211 211
Lines 10850 10854 +4
========================================
- Hits 9720 5552 -4168
- Misses 1130 5302 +4172 |
stancld
reviewed
Jan 24, 2023
src/torchmetrics/functional/classification/precision_recall_curve.py
Outdated
Show resolved
Hide resolved
stancld
approved these changes
Jan 24, 2023
Borda
approved these changes
Jan 24, 2023
src/torchmetrics/functional/classification/precision_recall_curve.py
Outdated
Show resolved
Hide resolved
Borda
pushed a commit
that referenced
this pull request
Jan 30, 2023
Co-authored-by: stancld <daniel.stancl@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit 94c49f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1443
Add missing dtype check on the
targettensor for PR-curve metric, which leads to unwanted errors later in the code.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃