Fix ignore_index in jaccard index #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
force-pushed
the
bugfix/multiclass_jaccard
branch
from
6652c55
to
34466d7
Compare
|
@SkafteNicki is this ready for review? 馃惏 |
SkafteNicki
changed the title
SkafteNicki
requested review from
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
========================================
- Coverage 87% 50% -37%
========================================
Files 219 219
Lines 11528 11531 +3
========================================
- Hits 10007 5776 -4231
- Misses 1521 5755 +4234 |
Borda
approved these changes
Feb 24, 2023
justusschock
approved these changes
Feb 27, 2023
Borda
pushed a commit
that referenced
this pull request
Feb 27, 2023
(cherry picked from commit 18aa8da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1385
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭