Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kendall Rank Correlation Coefficient (Kendall's tau) #1271

Merged
merged 51 commits into from Nov 3, 2022

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Oct 15, 2022

What does this PR do?

Fixes #1206

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@stancld stancld added this to the v0.11 milestone Oct 15, 2022
@stancld stancld changed the title [WIP] Add Kendall's tau Add Kendall's tau Oct 16, 2022
@SkafteNicki
Copy link
Member

@Borda can you help land this. Code works as expected but currently one general mypy check is failing with:

error: --install-types failed (no mypy cache directory)

@SkafteNicki SkafteNicki enabled auto-merge (squash) October 25, 2022 14:13
@mergify mergify bot added ready and removed ready labels Oct 27, 2022
@Borda
Copy link
Member

Borda commented Oct 28, 2022

@Borda can you help land this. Code works as expected but currently one general mypy check is failing with:

error: --install-types failed (no mypy cache directory)

hmmm never seen this before :/ let me check on MOnday 🐰

@stancld
Copy link
Contributor Author

stancld commented Oct 29, 2022

@SkafteNicki Do we wanna keep the last to commits adding new modules to mypy ignore list?

@SkafteNicki
Copy link
Member

@SkafteNicki Do we wanna keep the last to commits adding new modules to mypy ignore list?

Nope, have removed them again :)

@SkafteNicki
Copy link
Member

@Borda can you help land this. Code works as expected but currently one general mypy check is failing with:

error: --install-types failed (no mypy cache directory)

hmmm never seen this before :/ let me check on MOnday 🐰

The weird error was fixed in fefe505.
@stancld could you take care of the remaining mypy typing issues, mostly have to do with the use EnumStr

@mergify mergify bot added the ready label Oct 31, 2022
@stancld
Copy link
Contributor Author

stancld commented Nov 1, 2022

@Borda Should be ready for a final review :]

@SkafteNicki SkafteNicki merged commit ec27df1 into master Nov 3, 2022
@SkafteNicki SkafteNicki deleted the metric/kendall-tau branch November 3, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kendall's Rank Correlation
3 participants