Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating logos #18375

Merged
merged 5 commits into from
Aug 28, 2023
Merged

docs: updating logos #18375

merged 5 commits into from
Aug 28, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 23, 2023

What does this PR do?

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Borda Borda added the docs Documentation related label Aug 23, 2023
@Borda Borda added this to the 2.0.x milestone Aug 23, 2023
@github-actions github-actions bot added fabric lightning.fabric.Fabric app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package labels Aug 23, 2023
@Borda Borda marked this pull request as ready for review August 23, 2023 19:05
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-checks (fabric, doctest) success
make-html (fabric) success

These checks are required after the changes to docs/source-fabric/_static/images/logo.png, docs/source-fabric/_static/images/logo.svg, .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-checks (pytorch, doctest) success
make-html (pytorch) success

These checks are required after the changes to docs/source-pytorch/_static/images/logo.png, docs/source-pytorch/_static/images/logo.svg, .github/workflows/docs-build.yml.

🟢 lightning_app: Docs
Check ID Status
docs-checks (app, doctest) success
make-html (app) success

These checks are required after the changes to docs/source-app/_static/images/logo.png, docs/source-app/_static/images/logo.svg, .github/workflows/docs-build.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added the ci Continuous Integration label Aug 23, 2023
@awaelchli
Copy link
Contributor

awaelchli commented Aug 23, 2023

The texts are much smaller than before, and the subtitle "Created by Lightning AI" appears tiny on the generated website. Is this intentional?

@lantiga
Copy link
Collaborator

lantiga commented Aug 23, 2023

BTW it seems the new images have a different logos

image

@Borda
Copy link
Member Author

Borda commented Aug 23, 2023

The texts are much smaller than before, and the subtitle "Created by Lightning AI" appears tiny on the generated website. Is this intentional?

@alexlouiserose @likethecognac ^^

it seems the new images have a different logos

It seems we did not update it for a while...

@Borda
Copy link
Member Author

Borda commented Aug 23, 2023

this is how the docs will look like: https://pytorch-lightning--18375.org.readthedocs.build/en/18375/

@Borda Borda marked this pull request as draft August 24, 2023 12:45
@likethecognac
Copy link

yes, had called out the small copy size myself ,when we first added the byline, but it was intentionally on the smaller side. fwiw it's called micro in our design system and to be used sparingly. are you inserting that updated image into the same sized div? The added byline may be making it not fit into the original space as easily. here's a mock to share what is expected
image
@lantiga yes, the original icon (logo) and wordmark (brand text) was actually one typeface and a different custom wordmark for "lighting", so those two aren't even the same font. Keeping the sub brands in a more easily changeable format for now to more easily update for things like lit-LLaMA > Llama , or addign spaces or changing lit-parrot > GPT, etc.

@Borda Borda marked this pull request as ready for review August 24, 2023 21:23
@mergify mergify bot added the ready PRs ready to be merged label Aug 25, 2023
@awaelchli
Copy link
Contributor

We would need to slightly adjust the size to fit what is expected as pointed out by @likethecognac. If this is not controllable here in lightning, it might need adjustment in the docs template.

@Borda
Copy link
Member Author

Borda commented Aug 25, 2023

I believe we need to update this CSS to set some higher max size but preserve max-width:
https://github.com/Lightning-Universe/lightning_sphinx_theme/blob/2c040181e16bcfcf98a1c3d7fcc92ecfa984c7e1/scss/shared/_navigation.scss#L34
cc: @adamjkuhn

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low confidence on the logo changes. Approving to unblock

@Borda Borda merged commit 8218097 into master Aug 28, 2023
@Borda Borda deleted the docs/logo branch August 28, 2023 14:49
Borda added a commit that referenced this pull request Aug 28, 2023
(cherry picked from commit 8218097)
lantiga pushed a commit that referenced this pull request Aug 30, 2023
(cherry picked from commit 8218097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ci Continuous Integration docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants