-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updating logos #18375
docs: updating logos #18375
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_app: Docs
These checks are required after the changes to Thank you for your contribution! 💜
|
The texts are much smaller than before, and the subtitle "Created by Lightning AI" appears tiny on the generated website. Is this intentional? |
@alexlouiserose @likethecognac ^^
It seems we did not update it for a while... |
this is how the docs will look like: https://pytorch-lightning--18375.org.readthedocs.build/en/18375/ |
yes, had called out the small copy size myself ,when we first added the byline, but it was intentionally on the smaller side. fwiw it's called micro in our design system and to be used sparingly. are you inserting that updated image into the same sized div? The added byline may be making it not fit into the original space as easily. here's a mock to share what is expected |
We would need to slightly adjust the size to fit what is expected as pointed out by @likethecognac. If this is not controllable here in lightning, it might need adjustment in the docs template. |
I believe we need to update this CSS to set some higher max size but preserve max-width: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low confidence on the logo changes. Approving to unblock
(cherry picked from commit 8218097)
(cherry picked from commit 8218097)
What does this PR do?
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca @justusschock @awaelchli