Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLD Signing on macOS + Windows update #3779

Merged
merged 3 commits into from Jun 22, 2023
Merged

LLD Signing on macOS + Windows update #3779

merged 3 commits into from Jun 22, 2023

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Jun 22, 2023 •
edited

📝 Description

It seems our CI cannot sign / notarize macOS apps anymore. Looking at possible solutions
electron/notarize#109

❓ Context

  • Impacted projects: LLD
  • Linked resource(s):

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023 •
edited

⚠️ No Changeset found

Latest commit: 8a6dd7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
live-common-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 3:48pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 22, 2023 3:48pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 3:48pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 3:48pm

@github-actions github-actions bot added the desktop Has changes in LLD label Jun 22, 2023
@github-actions github-actions bot added cli common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM tools Has changes in tools ui Has changes in the design system library labels Jun 22, 2023
@github-actions github-actions bot removed ledgerjs Has changes in the ledgerjs open source libs cli ui Has changes in the design system library common Has changes in live-common labels Jun 22, 2023
@github-actions github-actions bot removed tools Has changes in tools mobile Has changes in LLM labels Jun 22, 2023
@valpinkman valpinkman changed the title LLD Signing on macOS LLD Signing on macOS + Windows update Jun 22, 2023
@valpinkman valpinkman marked this pull request as ready for review June 22, 2023 15:56
@valpinkman valpinkman requested a review from a team June 22, 2023 15:56
@valpinkman valpinkman merged commit 6ff8119 into develop Jun 22, 2023
25 of 33 checks passed
@valpinkman valpinkman deleted the bugfix/macos-certificate branch June 22, 2023 16:02
hedi-edelbloute pushed a commit that referenced this pull request Jun 22, 2023
@valpinkman @hedi-edelbloute
LLD Signing on macOS + Windows update (#3779)
8cc2a86 
* chore(deps): update electron-notarize to @electron/notarize

chore(dep): add missing debug

* chore(notarize): try catch the specific staple error

* chore(windows): update azure key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute approved these changes

@henri-ly henri-ly henri-ly approved these changes

Assignees

@valpinkman valpinkman

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valpinkman @hedi-edelbloute @henri-ly