Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of #907 #967

Closed
5 tasks done
DerGuteWolf opened this issue Nov 15, 2019 · 3 comments · Fixed by #1027
Closed
5 tasks done

Continuation of #907 #967

DerGuteWolf opened this issue Nov 15, 2019 · 3 comments · Fixed by #1027
Assignees
Labels

Comments

@DerGuteWolf
Copy link
Contributor

DerGuteWolf commented Nov 15, 2019

  • I'm reporting a bug, not asking for help
  • I'm sure this is a Leaflet.MarkerCluster code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
  • I've searched through the issues to make sure it's not yet reported

Unfortunatly my fix #909 for #907 was not complete, the recursive call in getAllChildMarkers needs to receive the new ignoreDraggedMarker Parameter.

How to reproduce

  • Leaflet version I'm using: 1.5.1
  • Leaflet.MarkerCluster version I'm using: 1.4.1
  • Leaflet.MarkerCluster.Freezable version I'm using: 1.0.0
  • Browser (with version) I'm using: Chrome
  • OS/Platform (with version) I'm using: Windows

What behaviour I'm expecting and which behaviour I'm seeing

run Fiddle, click on one of the bigger clusters (which will be a "multi-level" cluster thanks to the freeze), drag one marker from this cluster over another cluster:
Expected: Dragged marker still visible at mouse cursor
Seeing: Dragger marker disappears

Minimal example reproducing the issue

https://jsfiddle.net/7b4xzprd/1/

  • this example is as simple as possible
  • this example does not rely on any third party code
@ykzeng
Copy link
Collaborator

ykzeng commented Sep 4, 2021

@DerGuteWolf thanks for the issue and fix. but could u help me reproduce this issue? I tried in fiddle https://jsfiddle.net/7b4xzprd/1/ and the dragger marker did disappear, but when I try on local as well as on https://jsfiddle.net/7b4xzprd/show it seems the dragger marker is working as expected.

@ykzeng ykzeng reopened this Sep 4, 2021
@ykzeng ykzeng self-assigned this Sep 7, 2021
@ykzeng ykzeng added the bug label Sep 7, 2021
@DerGuteWolf
Copy link
Contributor Author

Hi @ykzeng ,

thanks for caring for the repo and merging my fix.

In your fiddle your are not freezing the cluster situation with

mcg.freezeAtZoom(11);

(this uses https://github.com/ghybs/Leaflet.MarkerCluster.Freezable).

The problem arises when the clusters are frozen and there is a cluster which when unfreezed and clicked on would result in clusters and not individual markers (ie a "multi-level" cluster).

Regards,
Wolfgang

@ykzeng
Copy link
Collaborator

ykzeng commented Sep 11, 2021

@DerGuteWolf hi Wolfgang, thanks for the comment. I was just able to reproduce the issue with freezing function and the fix works good. I will catch up on some other fixes and PRs and expect to have a new version soon with this fix.

And thanks for your nice words, I appreciate your contributions to the repo and look forward to working on your future PRs :)

Regards,
Vincent

@ykzeng ykzeng closed this as completed Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants