-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuation of #907 #967
Comments
@DerGuteWolf thanks for the issue and fix. but could u help me reproduce this issue? I tried in fiddle https://jsfiddle.net/7b4xzprd/1/ and the dragger marker did disappear, but when I try on local as well as on https://jsfiddle.net/7b4xzprd/show it seems the dragger marker is working as expected. |
Hi @ykzeng , thanks for caring for the repo and merging my fix. In your fiddle your are not freezing the cluster situation with mcg.freezeAtZoom(11); (this uses https://github.com/ghybs/Leaflet.MarkerCluster.Freezable). The problem arises when the clusters are frozen and there is a cluster which when unfreezed and clicked on would result in clusters and not individual markers (ie a "multi-level" cluster). Regards, |
@DerGuteWolf hi Wolfgang, thanks for the comment. I was just able to reproduce the issue with freezing function and the fix works good. I will catch up on some other fixes and PRs and expect to have a new version soon with this fix. And thanks for your nice words, I appreciate your contributions to the repo and look forward to working on your future PRs :) Regards, |
Unfortunatly my fix #909 for #907 was not complete, the recursive call in getAllChildMarkers needs to receive the new ignoreDraggedMarker Parameter.
How to reproduce
What behaviour I'm expecting and which behaviour I'm seeing
run Fiddle, click on one of the bigger clusters (which will be a "multi-level" cluster thanks to the freeze), drag one marker from this cluster over another cluster:
Expected: Dragged marker still visible at mouse cursor
Seeing: Dragger marker disappears
Minimal example reproducing the issue
https://jsfiddle.net/7b4xzprd/1/
The text was updated successfully, but these errors were encountered: