Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evict WorkerPool et al from core of disruptor #323

Closed
grumpyjames opened this issue Nov 18, 2020 · 4 comments · Fixed by #324 or #322
Closed

Evict WorkerPool et al from core of disruptor #323

grumpyjames opened this issue Nov 18, 2020 · 4 comments · Fixed by #324 or #322
Assignees
Projects
Milestone

Comments

@grumpyjames
Copy link
Member

These classes aren't used internally at LMAX; this makes it very difficult for us to act as maintainers of them. We're also not hugely convinced that using the disruptor in this way is a good fit for the underlying technology. I'm not going to get out the Jurassic Park scientist meme, but I feel I could.

Should we stop including those classes as part of the disruptor in 4.x? I think so...

@grumpyjames grumpyjames added this to To do in 4.0 Nov 18, 2020
Palmr added a commit to Palmr/disruptor that referenced this issue Nov 18, 2020
…removed, no more `Disruptor::handleEventsWithWorkerPool`
@Palmr Palmr moved this from To do to In progress in 4.0 Nov 19, 2020
@Palmr Palmr added this to the 4.0 milestone Nov 19, 2020
@Palmr Palmr moved this from In progress to Done in 4.0 Nov 27, 2020
@adol001
Copy link

adol001 commented Feb 14, 2022

In version 4.x, is there a successor to Disruptor::handleEventsWithWorkerPool? Can multiple consumers cooperate to process a batch of messages? (one message will only be processed by one consumer)

@denis-adamchuk
Copy link

FAQ still mentions WorkerPool which is confusing. Consider cleaning-it up.

@otaviocarvalho
Copy link

otaviocarvalho commented Apr 5, 2023

@grumpyjames how is that used internally at LMAX? Do you folks cover the standard way of using it somewhere (e.g. a blog post)?

@grumpyjames
Copy link
Member Author

To be clear: we don't use worker pool at LMAX; that's why we feel uncomfortable supporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4.0
Done
5 participants