Update Kotlin to 2.1.0 #4284
Update Kotlin to 2.1.0 #4284
Conversation
| @@ -153,6 +153,7 @@ public suspend fun <T> withContext( | |||
| // FAST PATH #1 -- new context is the same as the old one | |||
| if (newContext === oldContext) { | |||
| val coroutine = ScopeCoroutine(newContext, uCont) | |||
| @Suppress("LEAKED_IN_PLACE_LAMBDA") // Contract is preserved, invoked immediately or throws | |||
There was a problem hiding this comment.
This one (an one on the contract definition) is annoying, I'll report it to the team
| return@sc coroutine.startUndispatchedOrReturn(coroutine, block) | ||
| } | ||
| } | ||
| // SLOW PATH -- use new dispatcher | ||
| val coroutine = DispatchedCoroutine(newContext, uCont) | ||
| // Contract is preserved, invoked immediately or throws | ||
| @Suppress("LEAKED_IN_PLACE_LAMBDA") |
There was a problem hiding this comment.
I'd prefer that the comment is to the right of Suppress: typically, the comment above a line with a suppression refers to the line itself.
| kotlin_version=2.0.0 | ||
| kotlin_language_version=2.0 | ||
| kotlin_version=2.1.0 | ||
| kotlin_language_version=2.1 |
There was a problem hiding this comment.
Does this line do anything useful today other than accidentally disabling the "warnings are errors" flag?
There was a problem hiding this comment.
AFAIR release team uses it, but not sure. Will figure out separately
There was a problem hiding this comment.
The release team may override this property, this I get, but do we need to keep it in gradle.properties?
There was a problem hiding this comment.
At least for the sake of having "release team" branch and mainline having the same configuration and catching the same warnings/errors.
No description provided.