Workround #3881 breaks non-local returns in 1.8.0-RC

[Amejonah1200]

I recently upgraded the lib of one of my apps from 1.7.3 to 1.8.0-RC. I saw that something wasn't working a day later in my Grafana. After some investigations and deductions, I figured out that this bump caused functions not being executed, something had to do with locks.

After some time, I very professionally (using lots of printlns) debugged the whole code related to that feature. I found the bug out:

fun test() {
  mutex.withLock {
    return
  }
}

This doesn't release the lock. Why? Because someone decided to remove finally of that damn thing in #3881 .

https://kotlinlang.org/docs/inline-functions.html this even shows how to make a lock function which works. This will break a lot of code which relies on of having a finally out there.

[CLOVIS-AI]

Ouch, that's a pretty big oversight. I'll let the team chime in on this one, I have no idea how to fix this without bringing back the original bug.

[jakobkmar]

I have no idea how to fix this without bringing back the original bug.

Isn't the original compiler bug (KT-58685) fixed in Kotlin 1.9.30 (or at least 2.0.0)? I guess the workaround can be removed then?

[dkhalanskyjb]

Thank you for your immense professionalism! println FTW.

Also, thank you for making the RC process work as intended. Breakage is expected in RC, and the saddest thing is when we publish an RC, no one finds an issue, but after the release, all the production code is suddenly broken.

[werner77]

Could this be fixed with:

val result = try {
   action().also { unlock(owner) }
   ...