Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set XML report name to be the module name #527

Closed
MGaetan89 opened this issue Jan 24, 2024 · 6 comments · Fixed by #539
Closed

Set XML report name to be the module name #527

MGaetan89 opened this issue Jan 24, 2024 · 6 comments · Fixed by #539
Assignees
Labels
Feature Feature request issue type S: postponed Status: work on the issue is not in the short term plans

Comments

@MGaetan89
Copy link

What is your use-case and why do you need this feature?

Currently, the XML coverage report generated by Kover, when using the default engine, has its name set to Intellij Coverage Report, ie:

<report name="Intellij Coverage Report">

When using JaCoCo, the name is set to the module's name (for example :app).

Would it be possible to have the same behaviour for both engines? The report name may be used by other tools, for example https://github.com/marketplace/actions/jacoco-report. Having a unique/identifiable name for each report may then be useful.

Describe the solution you'd like

It would be great if Kover's default engine could use the module's name for the report name, instead of Intellij Coverage Report.

@MGaetan89 MGaetan89 added Feature Feature request issue type S: untriaged Status: issue reported but unprocessed labels Jan 24, 2024
@shanshin
Copy link
Collaborator

Thanks for the idea!

@shanshin shanshin added S: postponed Status: work on the issue is not in the short term plans and removed S: untriaged Status: issue reported but unprocessed labels Jan 24, 2024
@zuevmaxim
Copy link

@shanshin I'll need to extend com.intellij.rt.coverage.report.api.ReportApi#xmlReport with title parameter

zuevmaxim added a commit to JetBrains/intellij-coverage that referenced this issue Feb 6, 2024
@MGaetan89
Copy link
Author

I see that you already included the new title parameter @zuevmaxim, thank you 🙂

@shanshin once the changes mentioned above in intellij-coverage are released, are you open for external contributor to add the title parameter in Kover?

@shanshin
Copy link
Collaborator

shanshin commented Feb 9, 2024

@MGaetan89,
of course, with pleasure!

Early next week, we plan to release a minor release with a few minor fixes.

@shanshin
Copy link
Collaborator

Implemented in 0.7.6

@MGaetan89
Copy link
Author

Thanks for the quick release @shanshin!
I just updated to Kover 0.7.6, and it appears to be working fine 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request issue type S: postponed Status: work on the issue is not in the short term plans
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants