Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firefox] Strikethrough is placed a little above text #3156

Closed
vmishenev opened this issue Sep 1, 2023 · 2 comments · Fixed by #3436
Closed

[Firefox] Strikethrough is placed a little above text #3156

vmishenev opened this issue Sep 1, 2023 · 2 comments · Fixed by #3436
Assignees
@berezinant
Labels
bug format: html An issue/PR related to Dokka's default HTML output format html: frontend An issue/PR that only or primarily requires frontend work (html/css)

Comments

@vmishenev
Copy link
Member

vmishenev commented Sep 1, 2023 •
edited

image
Environment
Dokka 1.9.0
Firefox
@vmishenev vmishenev added bug format: html An issue/PR related to Dokka's default HTML output format labels Sep 1, 2023
@IgnatBeresnev
Copy link
Member

Cannot reproduce it with Chrome or Safari, but can reproduce it with Firefox, so seems quite specific.

Firefox 116.0.3

2023-09-01_17-21-44

Chrome 115.0.5790.170

2023-09-01_17-22-59

Safari 16.5.2

safari

If you don't mind, I'll rename the issue slightly to be like #2314, otherwise it looks way too scary when you first see the title :)

@IgnatBeresnev IgnatBeresnev changed the title [FRONTEND] Strikethrough is placed a little above text [Firefox] Strikethrough is placed a little above text Sep 1, 2023
@IgnatBeresnev IgnatBeresnev added the html: frontend An issue/PR that only or primarily requires frontend work (html/css) label Oct 20, 2023
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Dec 11, 2023
@berezinant
Copy link
Contributor

berezinant commented Dec 18, 2023 •
edited

Seems like this is a JetBrains Sans font peculiarity in firefox. For example:
JetBains Sans (has issue)
JetBrainsSans

JetBrains Mono (no issue)
jetbrains mono

system-ui (no issue)
system-ui

Different combinations of line-height/font-size/font-weight do nothing with it, so I'm currently not sure if there any chance to influence the issue other than changing the font or altering its source file

@IgnatBeresnev IgnatBeresnev removed this from the Dokka 2.0.0 milestone Dec 18, 2023
berezinant added a commit that referenced this issue Dec 28, 2023
@berezinant
fix: proper strikethrough in navigation for Fifefox #3156
c075ef4
@berezinant berezinant mentioned this issue Dec 28, 2023
Merged
berezinant added a commit that referenced this issue Jan 11, 2024
@berezinant
fix: proper strikethrough in navigation for Fifefox #3156
de8ab35
berezinant added a commit that referenced this issue Jan 11, 2024
@berezinant
fix: proper strikethrough in navigation for Fifefox #3156 (#3436)
d416612
IgnatBeresnev pushed a commit that referenced this issue Jan 11, 2024
@berezinant @IgnatBeresnev
fix: proper strikethrough in navigation for Fifefox #3156 (#3436)
5324006 
(cherry picked from commit d416612)
vmishenev pushed a commit that referenced this issue Mar 20, 2024
@berezinant @vmishenev
fix: proper strikethrough in navigation for Fifefox #3156 (#3436)
189b127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berezinant berezinant

Labels
bug format: html An issue/PR related to Dokka's default HTML output format html: frontend An issue/PR that only or primarily requires frontend work (html/css)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: proper strikethrough in navigation for Fifefox #3156 Kotlin/dokka
3 participants
@berezinant @vmishenev @IgnatBeresnev