Add missing group and description for Multimodule tasks #2806
+69
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TWiStErRob
commented
Jan 10, 2023
TWiStErRob
commented
TWiStErRob
changed the title
TWiStErRob
changed the title
There was a problem hiding this comment.
I noticed that the ReplaceWith for DokkaMultimoduleTask contains an error - it suggests to replace it with itself. Could you please correct it while we're at it?
And changing the deprecation level to ERROR would be nice as well, it's been under WARNING for 2.5 years, I think it's enough time to migrate :)
runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/DokkaPlugin.kt
Outdated
Show resolved
Hide resolved
IgnatBeresnev
approved these changes
Feb 1, 2023
atyrin
pushed a commit
that referenced
this pull request
Feb 6, 2023
* Change warning level as requested #2806 (review) * Change the group of deprecated tasks to "deprecated" according to conversation https://github.com/Kotlin/dokka/pull/2806/files#r1093042654 * Use lazy resolution of tasks and explicit test for deprecation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.