Disable copy button for signatures #2577
Merged
+88
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
commented
Jul 20, 2022
| @@ -95,7 +95,6 @@ open class HtmlRenderer( | |||
| } | |||
| node.dci.kind in setOf(ContentKind.Symbol) -> div("symbol $additionalClasses") { | |||
| childrenCallback() | |||
| if (node.hasStyle(TextStyle.Monospace)) copyButton() | |||
There was a problem hiding this comment.
This is the only real change in this PR. The rest is either formatting or to make tests pass
Closed
vmishenev
reviewed
Jul 26, 2022
There was a problem hiding this comment.
I suppose some styles, that are related to symbol, are redundant.
|
Indeed, hopefully I got all of it |
And here |
Are you sure you're looking at the right commit? Or maybe the link is wrong? See https://github.com/Kotlin/dokka/pull/2577/files#diff-316e3e9b3d50ff73dcc848844e5eaac72b2d38b7f1e84dca8a383a8b2c5a162c |
|
My fault, the link is wrong. |
|
Jesus :) Yeah, removed |
vmishenev
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy button itself and the script for it are still present for two scenarios:
See #2576