Update ASM to 9.7 to support class files generated for Java 23 #284
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shanshin and as you envisioned, compatibility tests are pretty useless when it comes to catching these errors. |
shanshin
approved these changes
Dec 18, 2024
|
@fzhinkin, do you know if there is a new version of the |
|
Nope, |
|
This also should support JDK 24, too! |
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Dec 22, 2024
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.assertj:assertj-core](https://assertj.github.io/doc/#assertj-core) ([source](https://github.com/assertj/assertj)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.26.3` -> `3.27.0` | | [org.jetbrains.kotlinx.binary-compatibility-validator](https://github.com/Kotlin/binary-compatibility-validator) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `0.16.3` -> `0.17.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.37` -> `2.29.39` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.37` -> `2.29.39` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.37` -> `2.29.39` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.37` -> `2.29.39` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.37` -> `2.29.39` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.37` -> `2.29.39` | --- ### Release Notes <details> <summary>Kotlin/binary-compatibility-validator (org.jetbrains.kotlinx.binary-compatibility-validator)</summary> ### [`v0.17.0`](https://github.com/Kotlin/binary-compatibility-validator/releases/tag/0.17.0) [Compare Source](Kotlin/binary-compatibility-validator@0.16.3...0.17.0) #### What's Changed - `$suspendImpl` functions are now filtered from dumps ([#​271](Kotlin/binary-compatibility-validator#271)) This change may cause validation failures for projects where dumps already contain such functions. It is recommended to regenerate dumps (`apiDump` task) after updating the BCV to `0.17.0`. - Supported class files generated for JVM target 23 ([#​284](Kotlin/binary-compatibility-validator#284)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 93958c08cfec442c4c0ece414e7da1959e0e9aa9
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
|
Just happened to notice that while version 0.17.0 supposedly contains this change to switch to newer asm, that does not appear to be the case. I am using 0.17.0 of BCV and it says that we are using 9.6 of asm. Here is a report from dependencyUpdates task: Doesn't really make a difference to me since we are using JDK 17, but was checking what dependencies we could upgrade and was trying to figure out where the asm dependency was coming from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.