feat(consumers): new empty state [khcp-14823] #1921
Merged
+104
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrzhussain
reviewed
Jan 31, 2025
| @@ -49,6 +49,31 @@ | |||
| </Teleport> | |||
| </template> | |||
|
|
|||
| <template | |||
| v-if="enableV2EmptyStates && config.app === 'konnect'" | |||
There was a problem hiding this comment.
suggestion: can we move 'konnect' to a constant
There was a problem hiding this comment.
Looking at it, that kind of refactor would be too large and I can't see an easy way forward without making the change for all entities in a single PR. Can you create a separate ticket for this work?
adamdehaven
reviewed
Feb 3, 2025
packages/entities/entities-consumers/src/components/ConsumerList.vue
Outdated
Show resolved
Hide resolved
TT1228
pushed a commit
that referenced
this pull request
Feb 17, 2025
Shared changes to `EntityBaseTable` for new empty states + usage in consumers. Part of [KHCP-14823](https://konghq.atlassian.net/browse/KHCP-14823).
TT1228
pushed a commit
that referenced
this pull request
Feb 18, 2025
Shared changes to `EntityBaseTable` for new empty states + usage in consumers. Part of [KHCP-14823](https://konghq.atlassian.net/browse/KHCP-14823).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shared changes to
EntityBaseTablefor new empty states + usage in consumers.Part of KHCP-14823.