Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entityemptystate): added appreance prop support [KHCP-14905] #1919

Merged
merged 6 commits into from
Feb 3, 2025
Merged

feat(entityemptystate): added appreance prop support [KHCP-14905] #1919

merged 6 commits into from
Feb 3, 2025
+49 −6

Conversation

afrzhussain
Copy link
Contributor

@afrzhussain afrzhussain commented Jan 30, 2025 •
edited
Loading

Summary
JIRA : https://konghq.atlassian.net/browse/KHCP-14905

  • Added appearance prop with 'primary' and 'secondary' options to support L2 empty states. The secondary appearance has a slightly smaller title font size.
  • Fixed feature cards taking up unnecessary space when features are empty.

@afrzhussain afrzhussain requested review from a team as code owners January 30, 2025 12:11
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@afrzhussain
fix(entityemptystate): props docs, improvements [KHCP-14905]
Loading
Loading status checks…
a2a1f97
@afrzhussain
fix: type imports
Loading
Loading status checks…
4616a13
@afrzhussain
fix: fixed computed naming
Loading
Loading status checks…
35526e3
kaiarrowood
kaiarrowood previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kaiarrowood kaiarrowood dismissed stale reviews from adamdehaven and themself January 31, 2025 16:17

Issues addressed

@afrzhussain
fix: type imports
Loading
Loading status checks…
ae7b291
kaiarrowood
kaiarrowood approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@afrzhussain afrzhussain merged commit e8cda9b into main Feb 3, 2025
22 checks passed
@afrzhussain afrzhussain deleted the feat/KHCP-14905-add-appearance-in-entity-empty-state branch February 3, 2025 12:18
TT1228 pushed a commit that referenced this pull request Feb 17, 2025
@afrzhussain @TT1228
feat(entityemptystate): added appreance prop support [KHCP-14905] (#1919
f099451 
)

* feat(entityemptystate): added appreance prop support [KHCP-14905]

* fix(entityemptystate): props docs, improvements [KHCP-14905]

* fix: type imports

* fix(entityemptystate): fixed all spacing issues [KHCP-14905]

* fix: fixed computed naming

* fix: type imports
TT1228 pushed a commit that referenced this pull request Feb 18, 2025
@afrzhussain @TT1228
feat(entityemptystate): added appreance prop support [KHCP-14905] (#1919
6c15abf 
)

* feat(entityemptystate): added appreance prop support [KHCP-14905]

* fix(entityemptystate): props docs, improvements [KHCP-14905]

* fix: type imports

* fix(entityemptystate): fixed all spacing issues [KHCP-14905]

* fix: fixed computed naming

* fix: type imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiarrowood kaiarrowood

@adamdehaven adamdehaven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@afrzhussain @CLAassistant @adamdehaven @kaiarrowood