Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make telemetry related variables const again in internal/manager/telemetry/manager.go #4119

Closed
2 tasks done
programmer04 opened this issue Jun 1, 2023 · 0 comments · Fixed by #4144
Closed
2 tasks done

Make telemetry related variables const again in internal/manager/telemetry/manager.go #4119

programmer04 opened this issue Jun 1, 2023 · 0 comments · Fixed by #4144
Assignees
@programmer04
Labels
area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests

Comments

@programmer04
Copy link
Member

programmer04 commented Jun 1, 2023 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

PR #4058 made

SplunkEndpoint
SplunkEndpointInsecureSkipVerify
TelemetryPeriod

variables non-const and global to allow adjustments for proper testing. Having mutable package level variables is not the best and brings some issues.

Proposed Solution

Changing them back into const and adding options to customise them. Probably manager's Config has to be used (or maybe it's a better way...). We don't have to expose the CLI's flag for user to make them configurable.

Additional information

No response

Acceptance Criteria

  • values provided via SplunkEndpoint, SplunkEndpointInsecureSkipVerify, TelemetryPeriod are configurable without being package global variables
@programmer04 programmer04 added area/debt area/tests area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Jun 1, 2023
This was referenced Jun 1, 2023
Merged
Merged
@programmer04 programmer04 self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programmer04 programmer04

Labels
area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: make telemetry related variables const again Kong/kubernetes-ingress-controller
1 participant
@programmer04