Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify code for dealing with cert creation in tests #4118

Closed
2 tasks done
programmer04 opened this issue Jun 1, 2023 · 0 comments · Fixed by #4543
Closed
2 tasks done

Unify code for dealing with cert creation in tests #4118

programmer04 opened this issue Jun 1, 2023 · 0 comments · Fixed by #4543
Assignees
@programmer04
Labels
area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests

Comments

@programmer04
Copy link
Member

programmer04 commented Jun 1, 2023 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

There are couple of places where TLS, etc. servers/clients are required in tests e.g.

Proposed Solution

Let's deduplicate code and create helpers that will be reused

Additional information

No response

Acceptance Criteria

  • no more unnecessary duplication of TLS related code or hardcoded certs in tests
@programmer04 programmer04 mentioned this issue Jun 1, 2023
Merged
1 task
@programmer04 programmer04 added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Jun 1, 2023
@programmer04 programmer04 mentioned this issue Jul 3, 2023
Closed
1 task
@randmonkey randmonkey mentioned this issue Jul 4, 2023
Merged
@programmer04 programmer04 mentioned this issue Jul 6, 2023
Merged
This was referenced Aug 10, 2023
Merged
Merged
@programmer04 programmer04 self-assigned this Aug 10, 2023
@programmer04 programmer04 mentioned this issue Aug 11, 2023
Merged
@programmer04 programmer04 mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programmer04 programmer04

Labels
area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests
Projects
None yet
Milestone
No milestone
1 participant
@programmer04