Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle const Type Parameters #519

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: handle const Type Parameters #519

merged 3 commits into from
Oct 22, 2024
+157 −28

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented May 22, 2024 •
edited
Loading

PR Checklist

Overview

Initial attempt at resolving the issue.
I've got no idea if this is the correct approach or not.
There might be some cases which this PR doesn't currently handle.

Sorry, something went wrong.

@RebeccaStevens RebeccaStevens force-pushed the issue-518-initial branch 3 times, most recently from 372beb6 to 0f27bef Compare May 23, 2024 02:33
@RebeccaStevens RebeccaStevens marked this pull request as draft May 23, 2024 02:34
@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented May 25, 2024 •
edited
Loading

@JoshuaKGoldberg I just cleaned up this PR a bunch and made it a bit more robust.

@RebeccaStevens RebeccaStevens marked this pull request as ready for review May 25, 2024 04:59
@RebeccaStevens RebeccaStevens mentioned this pull request May 25, 2024
Open
6 tasks
@RebeccaStevens
fix: handle const Type Parameters

Verified

This commit was signed with the committer’s verified signature.
almeidx Almeida
SSH Key Fingerprint: qS0Cyf/f5WBfKn8/H4i/7ypvfzpDKWVUeWx0miBkikA
Verified
Learn about vigilant mode
Loading
Loading status checks…
74a5952
@JoshuaKGoldberg
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
7663d76
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 22, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this looks good to me. Thanks!

@JoshuaKGoldberg
Merge branch 'main' into issue-518-initial

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
9c92710
@JoshuaKGoldberg
Copy link
Owner

Builds are very broken on main right now. I filed #530 to use the latest pnpm. Anyway, this has been ready for a while, and I just lost track of it 🤦

@JoshuaKGoldberg JoshuaKGoldberg merged commit 41cd21d into main Oct 22, 2024
24 of 40 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the issue-518-initial branch October 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: symbolHasReadonlyDeclaration doesn't support const type parameters
2 participants
@RebeccaStevens @JoshuaKGoldberg