Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Codecov now needs a CODECOV_ACTION token in v4 #1435

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 30, 2024 · 1 comment · Fixed by #1436
Closed
3 tasks done

🐛 Codecov now needs a CODECOV_ACTION token in v4 #1435

JoshuaKGoldberg opened this issue Mar 30, 2024 · 1 comment · Fixed by #1436
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 30, 2024 •
edited

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Codecov is a wonderful service that allows historical tracking of code coverage data. I use it in create-typescript-app and many other projects to upload code coverage data on every commit to main and PRs.

But, recent breaking changes to the first party Codecov GitHub Action have really messed with my ability to use it. It seems to now require a CODECOV_ACTION token for all repositories, even public open source ones.

This is disruptive. I filed codecov/codecov-action#1348 to suggest erroring by default and codecov/feedback#315 to give feedback on the breaking change.

In the meantime, this repo will have to either:

  • tell users to add a CODECOV_ACTION token for code coverage tracking
    • And all my repositories will need to have that token added. 😮‍💨
  • pin the Codecov action to v3

Additional Info

Brief notes on a few relevant issues and PRs:

  1. September 1st, 2023: use cli instead of node uploader codecov/codecov-action#1068 was sent to the Codecov repo to switch from the Codecov Node.js uploader to its CLI
  2. January 31st, 2024: https://github.com/codecov/codecov-action/releases/tag/v4.0.0 was released with that PR, explicitly removing support for tokenless uploading.
    • The release notes indicate PRs made from forks to the upstream public repos will still support it. Some users are reporting that that's not the case.
    • Notably, tokenless uploads aren't changed to fail the build. The action still passes with a no-op result.
  3. February >=3, 2024: Automated Renovate PRs start updating create-typescript-app repositories automatically to the new version.
  4. February 14th, 2024: Provide clarity on future of tokenless uploads from GitHub Actions codecov/codecov-action#1293 was filed to ask the Codecov team for clarity on the situation
  5. March 12th, 2024: Document how to properly setup Codecov Github Action for OpenSource repositories codecov/feedback#301 was filed asking for clarity on how to set up the action
  6. March 30th, 2024: I filed fail_ci_if_error should default to true codecov/codecov-action#1348 and Feedback: communication around GitHub Action removing support for token-less uploads codecov/feedback#315
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Mar 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Codecov now needs a CODECOV_ACTION token 🐛 Codecov now needs a CODECOV_ACTION token in v4 Mar 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 30, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 30, 2024
@JoshuaKGoldberg
fix: ignore codecov-action in renovate.json (#1436)
b98f533 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1435
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Altogether stops repositories from being upgraded to
`codecov/codev-action@v4`.

This can always be revisited if & when Codecov provides more details on
tokenless uploads
(codecov/codecov-action#1293).
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.57.10 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore codecov-action in renovate.json JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg