Ignore RCS1043 for WPF classes that inherit from FrameworkElement #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josefpihrt can you merge and release another version please? Thanks! |
josefpihrt
requested changes
Aug 21, 2023
src/Analyzers/CSharp/Analysis/RemovePartialModifierFromTypeWithSinglePartAnalyzer.cs
Outdated
Show resolved
Hide resolved
…ovaz/Roslynator into feature/take-wpf-into-account
|
@bdovaz Please update changelog. |
Done! EDIT: Also fixed broken links in CHANGELOG file |
josefpihrt
reviewed
Aug 21, 2023
josefpihrt
approved these changes
Aug 21, 2023
|
Thanks for the PR! |
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
…tnet#1176) Co-authored-by: Josef Pihrt <josef@pihrt.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1174
Analyzing WPF frameworks like Prism and reading the official documentation, it seems that taking into account the
FrameworkElementclass is enough. If it is not, it will be easy to modify it in the future.References:
https://learn.microsoft.com/en-us/dotnet/desktop/wpf/advanced/base-elements
https://learn.microsoft.com/en-us/dotnet/desktop/wpf/advanced/base-elements-overview
https://github.com/PrismLibrary/Prism/tree/master/src/Wpf/Prism.Wpf