Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .net 8 #2176

Merged
merged 1 commit into from Nov 24, 2023
Merged

Upgrade to .net 8 #2176

merged 1 commit into from Nov 24, 2023

Conversation

JeremySkinner
Copy link
Member

No description provided.

@JeremySkinner JeremySkinner merged commit 40f1cc8 into main Nov 24, 2023
3 checks passed
@JeremySkinner JeremySkinner deleted the upgrade/net8 branch November 24, 2023 10:21
@DanteDeRuwe
Copy link

@JeremySkinner any idea when this change will be part of a release? It is currently holding back our upgrade to .NET 8. Thanks in advance for your reply!

@JeremySkinner
Copy link
Member Author

JeremySkinner commented Dec 5, 2023

hi @DanteDeRuwe the current .NET 6 & 7 releases of FluentValidation should work just fine on .NET 8. There's no need to wait on a specific .NET 8 release. .NET 8 is already implicitly supported.

This PR was mainly just to update our internal unit tests to run on .NET 8 too.

If you're running into a problem with using the current release on .NET 8 please open a separate issue.

@DanteDeRuwe
Copy link

@JeremySkinner Thanks for the quick response. I fixed the issue I had without knowing how and without any way to reproduce it. One of those days am I right? Have a nice one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants