Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak enumerator #2174

Merged
merged 3 commits into from Nov 22, 2023
Merged

Conversation

kronic
Copy link
Contributor

@kronic kronic commented Nov 22, 2023

No description provided.

@JeremySkinner
Copy link
Member

JeremySkinner commented Nov 22, 2023

Hi, thanks for the suggestion.

This has the unintended sideffect of causing any uses of System.Linq.IEnumerable<T>.Any within the codebase to be switched to using this method in files where the FluentValidation.Internal namespace is imported (as this namespace is more specific).

I've moved this to be a private non-extension method within the specific validators which resolves this and is a pattern I prefer as I don't think we need a globally available method for this.

@JeremySkinner JeremySkinner merged commit 419380c into FluentValidation:main Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants