Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemberNameValidator to work with indexes in path #2056

Merged
merged 4 commits into from Jan 30, 2023

Conversation

abramchev
Copy link
Contributor

Hi!
Little changes and tests to allow MemberNameValidatorSelector to work with indexes and wildcard []. Is it the way you thought?

@dnfadmin
Copy link
Collaborator

dnfadmin commented Jan 22, 2023

CLA assistant check
All CLA requirements met.

@JeremySkinner
Copy link
Member

Thanks. I have limited availability for the next week but will aim to get this reviewed after that

@JeremySkinner
Copy link
Member

Thanks for this - it was a good starting point. I’ve made a few changes to it and merged it

  • Updated the regex to handle non-numeric collection indices
  • Added support for nested collections
  • Switch to a compiled and cached regex
  • Moved the tests into the same file as the other IValidatorSelector tests
  • Updated tests to use the public API
  • Fixed code style issues

I'll update the docs prior to publishing a release

@JeremySkinner JeremySkinner merged commit 2fed490 into FluentValidation:main Jan 30, 2023
@JeremySkinner JeremySkinner added this to the 11.5 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemberNameValidatorSelector does not work with property path to child rule after version 11.1.1
3 participants