Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imgur image resolution, image input stream reading #2637

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

  • Added better error handling in case of non-2xx responses
  • Create ImageInputStream (images did not load for me otherwise)
  • Adds curl header to imgur requests (otherwise response will always be 429)

Submitter Checklist

Preview Give feedback

Verified

This commit was signed with the committer’s verified signature.
mtoffl01 Mikayla Toffler
@PierreSchwang PierreSchwang requested a review from a team as a code owner March 19, 2024 22:29
@PierreSchwang PierreSchwang requested a review from dordsor21 March 19, 2024 22:29
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Mar 19, 2024
@PierreSchwang PierreSchwang merged commit 68eb24a into main Mar 20, 2024
9 checks passed
@PierreSchwang PierreSchwang deleted the fix/imageLoadingImgur branch March 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants