feat: implement a player-specific queue for clipboard IO tasks #2267
+211
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Jun 4, 2023
dordsor21
commented
- Addresses //copy - java.nio.channels.OverlappingFileLockExcption: null #2222 (hopefully fixes)
- Addresses #2222 (hopefully fixes)
|
Hey @skrevt, do you mind testing with the PR build whether this resolves your issue or not? |
|
The clipboard issue will be intermittent and isn't particularly easy to replicate, so it's more an over-time test kinda thing |
Merged
SirYwell
requested changes
Jun 5, 2023
...dedit-core/src/main/java/com/fastasyncworldedit/core/util/task/KeyQueuedExecutorService.java
Outdated
Show resolved
Hide resolved
| doc.close(); // Ensure closed before deletion | ||
| doc.getFile().delete(); | ||
| }); | ||
| } | ||
| } | ||
| } else if (Settings.settings().CLIPBOARD.DELETE_ON_LOGOUT || Settings.settings().CLIPBOARD.USE_DISK) { | ||
| WorldEdit.getInstance().getExecutorService().submit(() -> session.setClipboard(null)); | ||
| } else if (Settings.settings().CLIPBOARD.USE_DISK) { |
There was a problem hiding this comment.
I guess this is fine for now as it was like that before, but actually the clipboard can be set by plugins to arbitrary implementations, so relying on the settings isn't exactly correct.
...dedit-core/src/main/java/com/fastasyncworldedit/core/util/task/KeyQueuedExecutorService.java
Outdated
Show resolved
Hide resolved
...dedit-core/src/main/java/com/fastasyncworldedit/core/util/task/KeyQueuedExecutorService.java
Outdated
Show resolved
Hide resolved
...dedit-core/src/main/java/com/fastasyncworldedit/core/util/task/KeyQueuedExecutorService.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/Fawe.java
Outdated
Show resolved
Hide resolved
SirYwell
requested changes
Jun 6, 2023
...dedit-core/src/main/java/com/fastasyncworldedit/core/util/task/KeyQueuedExecutorService.java
Outdated
Show resolved
Hide resolved
...dedit-core/src/main/java/com/fastasyncworldedit/core/util/task/KeyQueuedExecutorService.java
Outdated
Show resolved
Hide resolved
dordsor21
force-pushed
the
feat/player-clipboard-queues
branch
from
99290ea to
999895c
Compare
SirYwell
approved these changes
Jun 6, 2023
NotMyFault
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.