Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: incremental estimators tests (backport #1998) #2021

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 2, 2024

Description

fixes incremental estimators tests.
Output array should be converted to numpy array before setting tol dependent on the dtype, otherwise the tol settings will not be set. Found on #1861


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

This is an automatic backport of pull request #1998 done by [Mergify](https://mergify.com).

Sorry, something went wrong.

* FIX: incremental  estimators tests

(cherry picked from commit 4fd4568)
@mergify mergify bot mentioned this pull request Sep 2, 2024
10 tasks
@samir-nasibli
Copy link

/intelci: run

@samir-nasibli
Copy link

CI fail are not related with the changes in the PR

@samir-nasibli samir-nasibli merged commit a205592 into rls/2024.7.0-rls Sep 2, 2024
16 of 17 checks passed
@mergify mergify bot deleted the mergify/bp/rls/2024.7.0-rls/pr-1998 branch September 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant