Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove SVM+neighbors GPU deselections #1991

Merged

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Aug 6, 2024

Description

Unclear what changes made these no longer an issue, but looks like there are no device issues on svm and neighbors conformance tests. Adds 750+ GPU conformance tests back into validation.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

Sorry, something went wrong.

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser ethanglaser marked this pull request as ready for review August 7, 2024 16:09
@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser ethanglaser changed the title CI: remove deselections CI: remove SVM+neighbors GPU deselections Aug 7, 2024
@ethanglaser
Copy link
Contributor Author

/intelci: run

1 similar comment
@ethanglaser
Copy link
Contributor Author

/intelci: run

Copy link
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy number of reactivations, CI looks good. Great job!

@icfaust
Copy link
Contributor

icfaust commented Aug 8, 2024

Private CI failures unrelated to reactivated tests.

Copy link
Contributor

@samir-nasibli samir-nasibli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

It would be good for the future to have a mechanism that would show how many tests were enabled within a certain fix.

As an idea, for this we can simply run tests without deselected and compare the crashes with the deselection list. It seems that it is not difficult to even automate

@ethanglaser ethanglaser merged commit a2b89b4 into uxlfoundation:main Aug 9, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants