Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: mpi-pytest follow-up deselections #1989

Merged

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Aug 6, 2024

Description

Follow-up to #1777. Deselecting some sporadically failing tests while resolution is underway.

Add a comprehensive description of proposed changes

List issue number(s) if exist(s): #6 (for example)


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

Sorry, something went wrong.

Copy link
Contributor

@md-shafiul-alam md-shafiul-alam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a temporary skip, and solution is in progress, I guess we can merge this.

Copy link

@samir-nasibli samir-nasibli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comment below

@ethanglaser
Copy link
Contributor Author

/intelci: run

Copy link
Contributor

@Alexsandruss Alexsandruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test should be explicitly skipped rather than commented.

@ethanglaser
Copy link
Contributor Author

/intelci: run

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…d.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…d.py

Co-authored-by: Samir Nasibli <samir.nasibli@intel.com>
@ethanglaser
Copy link
Contributor Author

/intelci: run

@samir-nasibli samir-nasibli dismissed their stale review August 7, 2024 15:04

Request is adressed.

Copy link

@samir-nasibli samir-nasibli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me! Assuming green CI

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…d.py
@ethanglaser
Copy link
Contributor Author

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser ethanglaser merged commit d7bd00b into uxlfoundation:main Aug 7, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants