-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sparse data support for LogisticRegression #1985
Merged
Alexsandruss
merged 5 commits into
uxlfoundation:main
from
avolkov-intel:dev/logreg-sparse
Aug 22, 2024
Merged
Add sparse data support for LogisticRegression #1985
Alexsandruss
merged 5 commits into
uxlfoundation:main
from
avolkov-intel:dev/logreg-sparse
Aug 22, 2024
+151
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/intelci: run |
Vika-F
reviewed
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Even versioning is in place.
For some reason I cannot see the results of pre-commit testing, but if everything is Ok there, then LGTM.
/intelci: run |
31332d0
to
1824953
Compare
/intelci: run |
Alexsandruss
requested changes
Aug 21, 2024
/intelci: run |
Alexsandruss
approved these changes
Aug 22, 2024
@Mergifyio copy rls/2024.7.0-rls |
✅ Pull request copies have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
(cherry picked from commit ce417b9)
10 tasks
Alexsandruss
pushed a commit
that referenced
this pull request
Aug 28, 2024
md-shafiul-alam
pushed a commit
to md-shafiul-alam/scikit-learn-intelex
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduce changes to support sparse data for Logistic Regression training and inference on GPU (for CPU sparse data will not be supported yet). Also a few tests were implemented
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance