Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse data support for LogisticRegression #1985

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

avolkov-intel
Copy link
Contributor

@avolkov-intel avolkov-intel commented Aug 2, 2024

Description

This PR introduce changes to support sparse data for Logistic Regression training and inference on GPU (for CPU sparse data will not be supported yet). Also a few tests were implemented

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

Sorry, something went wrong.

@avolkov-intel
Copy link
Contributor Author

/intelci: run

Copy link
Contributor

@Vika-F Vika-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Even versioning is in place.
For some reason I cannot see the results of pre-commit testing, but if everything is Ok there, then LGTM.

@avolkov-intel avolkov-intel marked this pull request as ready for review August 21, 2024 10:16
@avolkov-intel
Copy link
Contributor Author

/intelci: run

@avolkov-intel
Copy link
Contributor Author

/intelci: run

@avolkov-intel
Copy link
Contributor Author

/intelci: run

@Alexsandruss Alexsandruss merged commit ce417b9 into uxlfoundation:main Aug 22, 2024
18 checks passed
@avolkov-intel
Copy link
Contributor Author

@Mergifyio copy rls/2024.7.0-rls

Copy link

mergify bot commented Aug 22, 2024

copy rls/2024.7.0-rls

✅ Pull request copies have been created

mergify bot pushed a commit that referenced this pull request Aug 22, 2024
(cherry picked from commit ce417b9)
Alexsandruss pushed a commit that referenced this pull request Aug 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
(cherry picked from commit ce417b9)

Co-authored-by: Anatoly Volkov <117643568+avolkov-intel@users.noreply.github.com>
md-shafiul-alam pushed a commit to md-shafiul-alam/scikit-learn-intelex that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants